Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure that we actually force parse to UUID #814

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Jim-Encord
Copy link
Contributor

Switched type but wasn't actually coercing the data so types were being lied too. Non Pydantic serialisation hard! Requires checking

Copy link

github-actions bot commented Dec 3, 2024

Unit test report (Pydantic 1.x)

189 tests   189 ✅  5s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 791acd5.

Copy link

github-actions bot commented Dec 3, 2024

Unit test report ((Pydantic 2.x)

189 tests   189 ✅  6s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 791acd5.

@Jim-Encord Jim-Encord merged commit 8811495 into master Dec 4, 2024
5 of 6 checks passed
@Jim-Encord Jim-Encord deleted the jb/ensure-actually-make-uuid branch December 4, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants