Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates create_dataset to include all options #824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Laverne-Encord
Copy link
Collaborator

Includes content for 'create_backing_folder`

Includes content for 'create_backing_folder`
Copy link

Unit test report ((Pydantic 2.x)

193 tests   193 ✅  6s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit e10ec4b.

Copy link

Unit test report (Pydantic 1.x)

193 tests   193 ✅  5s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit e10ec4b.

Copy link

SDK integration test report

274 tests   274 ✅  21m 33s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit e10ec4b.

Copy link
Contributor

@alexey-cord-tech alexey-cord-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would maybe specify what the default is (true) and why (for backwards compat purposes); and suggested that callers use 'true' here at least if they want to interact with data previously uploaded to 'Files' or with Index collections, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants