misc: Revert removal of description used in Index #827
Conversation
Unit test report ((Pydantic 2.x)193 tests 193 ✅ 6s ⏱️ Results for commit 79e8285. ♻️ This comment has been updated with latest results. |
Unit test report (Pydantic 1.x)193 tests 193 ✅ 5s ⏱️ Results for commit 79e8285. ♻️ This comment has been updated with latest results. |
| @@ -56,6 +56,7 @@ class CreatePresetParams(BaseDTO): | |||
| class CreatePresetPayload(BaseDTO): | |||
| name: str | |||
| filter_preset_json: Dict | |||
| description: Optional[str] = "" | |||
There was a problem hiding this comment.
It may be worth refactoring this to have two separate Preset Types dependant on whether we are Active or Index. But that would be more code. Including a description erroneously in the payload for Active is kinda sad
There was a problem hiding this comment.
probably better to have separate types
Jim-Encord
force-pushed
the
jb/apparently-index-does-have-a-description
branch
from
00d4e49 to
79e8285
Compare
| self._client.patch( | ||
| f"index/presets/{self.uuid}", | ||
| params=None, | ||
| payload=payload, | ||
| result_type=None, | ||
| ) | ||
| self._preset_instance.name = name or self.name |
There was a problem hiding this comment.
Make it so we update local cache on successful update. Note that it falls after the request which will throw if unsuccessful.
| if not filter_preset.local_filters and not filter_preset.global_filters: | ||
| raise EncordException("We require there to be a non-zero number of filters in a preset") | ||
| payload = CreatePresetPayload( | ||
| payload = IndexCreatePresetPayload( | ||
| name=name, | ||
| filter_preset_json=filter_preset.to_dict(), |
There was a problem hiding this comment.
Note: Above we parse the input, just to immediately de-serialise it. Would it not be better to have it take a more structured object in the signature. Cc @Encord-davids. Theoretically breaks the interface but it's all somewhat fubar anyway
Introduction and Explanation
Index does apparently have a description. We should not have such bad duplicated functionality without tests