Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ED:511/change node to xpath #832

Merged
merged 31 commits into from
Jan 13, 2025
Merged

Conversation

clinton-encord
Copy link
Contributor

Introduction and Explanation

Rename HtmlNode's node property to xpath.

JIRA

Link ticket(s)

Documentation

There should be enough internal documentation for a product owner to write customer-facing documentation or a separate PR linked if writing the customer documentation directly. Link all that are relevant below.

  • Internal: notion link
  • Customer docs PR: link
  • OpenAPI/SDK
    • Generated docs: link to example if possible
    • Command to generate: here

Tests

Make a quick statement and post any relevant links of CI / test results. If the testing infrastructure isn’t yet in-place, note that instead.

  • What are the critical unit tests?
  • Explain the Integration Tests such that it’s clear Correctness is satisfied. Link to test results if possible.

Known issues

If there are any known issues with the solution, make a statement about what they are and why they are Ok to leave unsolved for now. Make tickets for the known issues linked to the original ticket linked above

Copy link

Unit test report ((Pydantic 2.x)

206 tests   206 ✅  6s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b4eab9e.

Copy link

Unit test report (Pydantic 1.x)

206 tests   206 ✅  6s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b4eab9e.

@clinton-encord
Copy link
Contributor Author

clinton-encord commented Jan 13, 2025

Note that integration tests here are failing because the BE also needs to be updated.

@clinton-encord clinton-encord merged commit 5d950dc into master Jan 13, 2025
5 of 6 checks passed
@clinton-encord clinton-encord deleted the clinton/ed-511/change-node-to-xpath branch January 13, 2025 15:47
clinton-encord added a commit that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants