Introduced factory method for model providers #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frederik-encord Using the types in the CLIP model causes |
frederik-encord
force-pushed
the
jb/factory_models
branch
from
c16121b to
328c025
Compare
…hs (#26) Now, if you run `poetry install` you can successively do ```bash $ clip-eval list ``` instead of ```bash $ PYTHONPATH=$PWD python src/cli.py list ``` I also refactored all files to import from `clip_eval` instead of src and other weird import paths.
frederik-encord
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the models use OpenCLIP as opposed to closed CLIP as such they are loaded differently and may embed slightly differently.
I have included a comment about not being able to type certain variables. Would appreciate some guidance on alleviating this. Also do try seeing if you can break it.