fix: broken models #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed `bioclip` model as we can use it directly from `open_clip` instead of HF. Also, the title of the apple model points to the right model now. Wrote a small refactor to remove ambiguity in the model title and optional `pretrained` tag. Known issues: `eva-clip` model can't be found by its name, we should look into this one.
Use model title in the cache folder instead of the source. We don't care much more about the separating by source than to be able to fetch, copy and delete individual models.
frederik-encord
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
bioclipmodel as we can use it directly fromopen_clipinstead of HF. Also, the title of the apple model points to the right model now.Wrote a small refactor to remove ambiguity in the model title and optional
pretrainedtag.Known issues:
eva-clipmodel wasn't found by title, we should investigate to confirm if this is because it requires additional customization.