Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always overwrite embeddings in CLI's build #49

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

eloy-encord
Copy link
Contributor

No description provided.

Copy link
Contributor

@Jim-Encord Jim-Encord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not obvious to me why you'd always want to overwrite Embeddings but LGTM

@eloy-encord
Copy link
Contributor Author

It's for the case when the user enables the selection of existing embeddings where these embeddings won't be saved as they already exist. It's an empty operation when the build command doesn't have any explicit flag so it's ok to always overwrite.

@eloy-encord eloy-encord merged commit 4306577 into main Mar 20, 2024
1 check passed
@eloy-encord eloy-encord deleted the eloy/fix-always-overwrite-embeddings-cli-build branch March 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants