chore: remove imports from common
submodule to other submodules
#61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove imports from
common
submodule to other submodules the following change were applied:build_embeddings()
fromEmbeddingDefinition
(was importingmodel
anddataset
submodules)build_embeddings()
fromEmbeddings
(was importingmodel
anddataset
submodules)Split
enum tocommon
submodule. This enum was imported fromdataset
and is also used inEmbeddingDefinition
, so now it lives incommon
and is still accessible from the init ofdataset
as it is also core to this submodule (an import that is easy to remember and use).As an extra, now
Embeddings
andEmbeddingsDefinition
live in the same file as they don't mingle with other data types anymore and are "always" imported together.