Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying a dtk binary #14

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

ribbanya
Copy link
Contributor

@ribbanya ribbanya commented Mar 3, 2024

@encounter
Copy link
Owner

For consistency with the other arguments, let's rename this to just --dtk

@ribbanya

This comment was marked as outdated.

@ribbanya

This comment was marked as outdated.

configure.py Outdated Show resolved Hide resolved
@ribbanya

This comment was marked as outdated.

@ribbanya ribbanya marked this pull request as draft March 4, 2024 07:22
@ribbanya ribbanya marked this pull request as ready for review March 4, 2024 07:24
@ribbanya ribbanya requested a review from encounter March 4, 2024 07:25
@ribbanya
Copy link
Contributor Author

ribbanya commented Mar 4, 2024

I think I'm done committing for real now.

❯ ./configure.py --help             
usage: configure.py [-h] [--version {GAMEID}] [--build-dir DIR] [--binutils BINARY] [--compilers DIR] [--map]
                    [--debug] [--wrapper BINARY] [--dtk BINARY | DIR] [--sjiswrap EXE] [--verbose]
                    [{configure,progress}]

positional arguments:
  {configure,progress}  script mode (default: configure)

options:
  -h, --help            show this help message and exit
  --version {GAMEID}    version to build
  --build-dir DIR       base build directory (default: build)
  --binutils BINARY     path to binutils (optional)
  --compilers DIR       path to compilers (optional)
  --map                 generate map file(s)
  --debug               build with debug info (non-matching)
  --wrapper BINARY      path to wibo or wine (optional)
  --dtk BINARY | DIR    path to decomp-toolkit binary or source (optional)
  --sjiswrap EXE        path to sjiswrap.exe (optional)
  --verbose             print verbose output

@encounter
Copy link
Owner

Looks great! I just caused you another merge conflict, sorry 🙃

@ribbanya
Copy link
Contributor Author

ribbanya commented Mar 4, 2024

Resolved.

@encounter encounter merged commit 1d3192a into encounter:main Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants