Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 706 implementation #23

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

PEP 706 implementation #23

wants to merge 13 commits into from

Conversation

encukou
Copy link
Owner

@encukou encukou commented Feb 21, 2023

This PR collects initial feedback & GH suggestions on the implementation.

Copy link

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are my comments and suggestions so far.

Lib/shutil.py Outdated Show resolved Hide resolved
Lib/shutil.py Show resolved Hide resolved
Lib/tarfile.py Outdated Show resolved Hide resolved
Lib/test/test_tarfile.py Show resolved Hide resolved
Copy link

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did another review and found only one issue in the documentation.

Doc/library/tarfile.rst Outdated Show resolved Hide resolved
Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants