Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluid image block size addition #35

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fluid image block size addition #35

merged 1 commit into from
Oct 27, 2023

Conversation

scottjehl
Copy link
Contributor

I noticed in a project that images that have width and height attrs were stretching in the block direction. I think I recall this is a typical remedy.

@scottjehl
fluid image block size addition
6f6ba47 
I noticed in a project that images that have width and height attrs were stretching in the block direction. I think I recall this is a typical remedy.
kristoferjoseph
kristoferjoseph approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@kristoferjoseph kristoferjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.
We've been doing a lot more aspect ratio where we aren't relying on width / height attrs so this would not have come up as much.
Thanks!

@kristoferjoseph kristoferjoseph merged commit e30f74c into main Oct 27, 2023
2 checks passed
@colepeters
Copy link
Member

👏🏻 ❤️

@colepeters colepeters deleted the img-block-auto branch October 27, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferjoseph kristoferjoseph kristoferjoseph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottjehl @colepeters @kristoferjoseph