Proposed fix per issue 470 #471
Conversation
There was a problem hiding this comment.
Thanks for contributing! High level, I think testnets stay around for a while after being considered deprecated so I think we should keep it marked as such rather than removing it completely at this point. If I'm wrong and its gettin fully shut down at the end of the month, then we should fully remove it.
CONTRIBUTING.md
Outdated
| 4. For a fresh clone, run `pnpm install` | ||
| 5. Build the docs locally with `pnpm run build` to ensure your changes are valid. | ||
|
|
||
| > Optionally, serve on local host with `pnpm dlx serve src/dist` to view your build in the browser. |
There was a problem hiding this comment.
I'd prefer to use the pnpm run dev command here instead of pnpm dlx serve (I know its different, but for sake of keeping things simple)
There was a problem hiding this comment.
interesting -- I did try pnpm run dev and that didn't serve while pnpm dlx serve src/dist did -- perhaps the url can be offered before server completes its tasks?
There was a problem hiding this comment.
Lets just mark the whole Holesky section as deprecated on line 154 instead of a specific contract
| <ContractDeployments chain="sepolia" /> | ||
|
|
||
| ### Holesky | ||
| {/*### Holesky |
There was a problem hiding this comment.
I think we should keep it until the chain is fully shut down, just mark it as "Holesky (Deprecated)"
uses alt
|
Closing in favor of #476 - notice of deprecation is sufficient for now until the chain actually goes offline. |
extends readme for prerequsites and deprecates Holesky