Universal Resolution by TateB · Pull Request #11 · ensdomains/ensips

TateB · 2024-10-14T21:20:20Z

"Universal Resolution" or "Universal Resolver" ?

cloudflare-workers-and-pages · 2024-10-14T21:31:23Z

Deploying ensips with Cloudflare Pages

Latest commit:	`ff6e440`
Status:	✅ Deploy successful!
Preview URL:	https://87a5d48d.ensips.pages.dev
Branch Preview URL:	https://ensip-universal-resolution.ensips.pages.dev

View logs

Arachnid

This needs to explicitly state that callers must handle CCIP-Read reverts.

makoto · 2025-01-16T19:25:19Z

Should the ENSIP mention upgrade paths or are they more of the implementation detail? I personally thinks it should be mentioned as A: if it's user initiated upgrade, there must be a public API that initiates the upgrade, B: If it's DAO initiated upgrade, there still needs a API DAO has to call and also the user should aware that the resolution logic is not immutable

Co-authored-by: Nick Johnson <arachnid@notdot.net>

TateB · 2025-03-19T16:09:13Z

@Arachnid by "callers", do you mean clients? or UniversalResolver implementations?

TateB · 2025-03-19T16:24:25Z

@makoto i don't think adding implementation detail on upgrade paths is worth it, upgradability is down to each individual implementation and it isn't particularly relevant to universal resolution itself imo

Arachnid

Can you add documentation for the errors defined in https://github.com/ensdomains/ens-contracts/pull/421/files#diff-895978e0de194cab98cef8af1c7de86d9a16ac5c37a1b33a5a28faf671f3bf14 too?

adraffy · 2025-05-24T03:10:22Z

I think we should include findResolver() in the interface too.

adraffy · 2025-07-28T22:30:37Z

I moved a bunch of stuff around and tried to simplify it.

I wanted a pseudocode example for forward resolution, but couldn't come up with anything simple w/o including too many cases, so I just left the Solidity and TypeScript usage examples.

A lot of specific details are covered in other ENSIPs so instead of repeating myself, I link out as much as possible, and focus on the mechanics.

Under "Smart Execution", I mention ENSIP-X as a placeholder for "ENSIP: Resolver Features", which I'm working on right now. Possibly, this explanation could be moved to that ENSIP, as this is (my take on) the best protocol for efficiently calling a resolver.

makoto · 2025-08-06T04:57:12Z

+`findResolver()` does not perform any validity checks on the resolver and simply returns the value in the registry.  The resolver may not be a contract or a resolver.
+
+#### <a name="resolve-example">Pseudocode Example</a>
+


It took a while to figure out what this Pseudocode Example does. Can you add a sentense like below explaining what the example does?

findResolver() walks up the domain hierarchy from "sub.nick.eth" to find the first parent domain with a resolver set (finds one at "nick.eth"), returning that resolver's address, the namehash of the original full name "sub.nick.eth", and the byte offset (4) indicating where in the DNS-encoded name the resolver was found.

It's defined in ENSIP-1. Additionally, this section will need revisited with ENSv2 as the traversal method changes.

makoto · 2025-08-06T04:59:43Z

+
+### resolve
+
+This function performs ENS forward resolution using the `resolver` found by [`findResolver()`](#findresolver).  It provides a standard interface for interacting [ENSIP-1](./1) and [ENSIP-10](./10) resolvers for onchain and offchain resolution.  Provided a DNS-encoded `name` and ABI-encoded `data`, it returns the ABI-encoded resolver `result` and the valid `resolver` address.


Like you did at EIP3668(CCIP-Read), worth adding ENSIP-1(ENS Protocol) and ENSIP-10(Wildcard) so that people don't have to click ENSIP to figure out what they actually are

I've been using the policy where I hyperlink the first time I mention something, and then rarely again unless its far away or I link to a specific anchor.

We could change the policy to all ENSIP references are linked, as that's an easy ENSIP-repo wide change, but might be noisy.

Changed in new PR, but only mentioned once.

#46

makoto · 2025-08-06T05:00:55Z

+
+This function performs ENS forward resolution using the `resolver` found by [`findResolver()`](#findresolver).  It provides a standard interface for interacting [ENSIP-1](./1) and [ENSIP-10](./10) resolvers for onchain and offchain resolution.  Provided a DNS-encoded `name` and ABI-encoded `data`, it returns the ABI-encoded resolver `result` and the valid `resolver` address.
+
+UR automatically handles wrapping calldata and unwrapping responses when interacting with an [`IExtendedResolver`](./10#pseudocode) and safely interacts with contracts deployed before [EIP-140](https://eips.ethereum.org/EIPS/eip-140).


EIP-140(REVERT instruction)

Changed in new PR.

makoto · 2025-08-06T05:04:00Z

+
+## Abstract
+
+This ENSIP standardizes [IUniversalResolver](#specification) (UR), an universal entrypoint for resolving ENS names.  UR incorporates onchain algorithms for [ENSIP-10](./10#pseudocode), [ENSIP-19](./19#algorithm), [ENSIP-21](./21), and [ENSIP-22](./22) to reduce ENS integration complexities.


Please put the title of each ENSIP (eg: ENSIP-10(Wildcard Resolution))

Changed in new PR.

makoto · 2025-08-06T05:13:11Z

+* If the called function reverted, reverts `ResolverError`.
+
+#### Smart Multicall
+


Is it worth noting that Smart Multicall allow you to combine multiple calls of one node, not being able to combine calls of multiple nodes? For example you can call addr and text of vitalik.eth in one call, but not combining addr of vitalik.eth and nick.eth even though you have to encode node in each call (for the backward compatibility purpose)

Yeah, agreed. I was relying on the existing resolve() interpretation but that should probably be explicitly stated so it's clear.

We also could add this feature to the UR, as its extremely easy to write with the current design.

There also is the following functions not included in the standard interface:

requireResolver()

resolveWithGateways()

reverseWithGateways()

resolveWithResolver()

Also, somewhere, we could document the multicall-like reverse primary name lookup that each reverse resolver supports. That could be an appendix of ENSIP-19 or a separate ENSIP. It was mentioned in the comments of this ENSIP above.

TateB added 2 commits October 14, 2024 11:34

initial draft

6879064

fix copyright heading

10052df

tweak headings

9c68560

Arachnid requested changes Oct 16, 2024

View reviewed changes

Comment thread ensips/x.md Outdated

Comment thread ensips/x.md Outdated

makoto reviewed Jan 16, 2025

View reviewed changes

Comment thread ensips/x.md Outdated

Update ensips/x.md

45504b9

Co-authored-by: Nick Johnson <arachnid@notdot.net>

clarified lookupAddress parameter

8b3dc5c

TateB requested review from Arachnid and makoto March 19, 2025 16:26

Arachnid reviewed Mar 20, 2025

View reviewed changes

add errors

d14a4ab

TateB marked this pull request as ready for review March 27, 2025 16:40

TateB requested a review from Arachnid March 27, 2025 16:40

TateB mentioned this pull request Mar 27, 2025

feat: universalresolver v3 support wevm/viem#3512

Closed

2 tasks

Arachnid requested changes Mar 27, 2025

View reviewed changes

Comment thread ensips/x.md Outdated

makoto reviewed May 23, 2025

View reviewed changes

Comment thread ensips/x.md Outdated

makoto reviewed May 23, 2025

View reviewed changes

Comment thread ensips/x.md Outdated

name => functionName

d79dd13

gskril mentioned this pull request Jul 5, 2025

Update universal resolver guide for library devs ensdomains/docs#445

Merged

adraffy added 3 commits July 23, 2025 15:26

wip

5274ac3

Merge branch 'master' into ensip/universal-resolution

2de1221

more wip

2377382

adraffy added 2 commits July 28, 2025 15:48

minor

025b601

more cleanup

0807c08

adraffy added 2 commits July 28, 2025 22:47

more cleanup

6a8a8a0

minor

b2475a9

adraffy requested a review from makoto July 31, 2025 23:09

adraffy added 3 commits July 31, 2025 18:11

minor

8fb85c7

remove smart execution

7451f52

'the UR' -> UR

f5ab122

TateB commented Aug 6, 2025

View reviewed changes

Comment thread ensips/x.md Outdated

permalink

c90b968

TateB commented Aug 6, 2025

View reviewed changes

Comment thread ensips/x.md Outdated

adraffy added 2 commits August 5, 2025 21:39

add bit about unnormalized primary

6816730

assign number, add feature

ff6e440

adraffy merged commit 976e781 into master Aug 6, 2025
2 checks passed

makoto reviewed Aug 6, 2025

View reviewed changes

adraffy deleted the ensip/universal-resolution branch August 6, 2025 06:36

TateB mentioned this pull request Aug 8, 2025

feat: UniversalResolver v3 support wevm/viem#3848

Merged

		`findResolver()` does not perform any validity checks on the resolver and simply returns the value in the registry. The resolver may not be a contract or a resolver.

		#### <a name="resolve-example">Pseudocode Example</a>


		### resolve

		This function performs ENS forward resolution using the `resolver` found by [`findResolver()`](#findresolver). It provides a standard interface for interacting [ENSIP-1](./1) and [ENSIP-10](./10) resolvers for onchain and offchain resolution. Provided a DNS-encoded `name` and ABI-encoded `data`, it returns the ABI-encoded resolver `result` and the valid `resolver` address.


		This function performs ENS forward resolution using the `resolver` found by [`findResolver()`](#findresolver). It provides a standard interface for interacting [ENSIP-1](./1) and [ENSIP-10](./10) resolvers for onchain and offchain resolution. Provided a DNS-encoded `name` and ABI-encoded `data`, it returns the ABI-encoded resolver `result` and the valid `resolver` address.

		UR automatically handles wrapping calldata and unwrapping responses when interacting with an [`IExtendedResolver`](./10#pseudocode) and safely interacts with contracts deployed before [EIP-140](https://eips.ethereum.org/EIPS/eip-140).


		## Abstract

		This ENSIP standardizes [IUniversalResolver](#specification) (UR), an universal entrypoint for resolving ENS names. UR incorporates onchain algorithms for [ENSIP-10](./10#pseudocode), [ENSIP-19](./19#algorithm), [ENSIP-21](./21), and [ENSIP-22](./22) to reduce ENS integration complexities.

		* If the called function reverted, reverts `ResolverError`.

		#### Smart Multicall

Conversation

TateB commented Oct 14, 2024 • edited by adraffy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages Bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying ensips with Cloudflare Pages

Uh oh!

Arachnid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

makoto commented Jan 16, 2025

Uh oh!

Uh oh!

TateB commented Mar 19, 2025

Uh oh!

TateB commented Mar 19, 2025

Uh oh!

Arachnid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adraffy commented May 24, 2025

Uh oh!

adraffy commented Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adraffy Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TateB commented Oct 14, 2024 •

edited by adraffy

Loading

cloudflare-workers-and-pages Bot commented Oct 14, 2024 •

edited

Loading

adraffy Aug 6, 2025 •

edited

Loading