Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async execution improvements #12282

Open
wants to merge 88 commits into
base: develop
Choose a base branch
from

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

  • Close https://github.com/enso-org/cloud-v2/issues/1739
    • Invalidate executions periodically (every minute) to make sure they are up to date
    • Fix path for deleting project executions
    • Use ISO dates for all dates - including the date input
    • Fix not being able to edit dates
    • Add combo box for selecting timezone
    • Hide selected option in dropdown so that it does not show up twice
    • Completely hide advanced options (execution time limit, parallel mode) by default
    • Rename "X of month" to "Monthly on X"
    • Change "daily" repeat type to mean every day
    • Add "weekly" repeat type
    • Remove "hourly" repeat type
    • Show count of executions per day in calendar cells instead of list of times
    • Only show three next repeat dates, and move to end
    • ⚠️ Not yet using the new endpoint yet to fetch execution status

Important Notes

None

Testing Instructions

  • Just test the adjustments above.
  • There was a refactor done to inputs (extracting a sub-component out) to make ComboBox work so other forms (anywhere) can be tested to make sure nothing is broken

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@somebody1234 somebody1234 force-pushed the wip/sb/async-execution-improvements branch from 035b29f to 9b46540 Compare February 20, 2025 12:26
@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Feb 21, 2025
@PabloBuchu
Copy link
Contributor

PabloBuchu commented Feb 21, 2025

  1. Make the inputs width for a whole dialog bog
  2. Move timezone as a first
  3. Add ... at the end of repeats indicating its just a sample
  4. First occurence should be affected by selected timezone (same with repeats)
  5. Lets add Last day of a month (be aware of Feb) type lastMonthDay with months
  6. When I choose Jan 31st and select monthly Feb is correct but later it stays at 28th...
Screenshot 2025-02-21 at 11 02 50
  1. This is not consistent
Screenshot 2025-02-21 at 11 05 04
  1. How it shows time? For Warsaw it shows 10:04 but we have 11:05

@somebody1234
Copy link
Contributor Author

should finally be addressed @PabloBuchu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants