API check for all standard libraries #12285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akirathan
added
the
CI: No changelog needed
5 tasks
| - default_widget display:Standard.Base.Metadata.Display= -> Standard.Base.Metadata.Widget | ||
| - rows_to_read self -> (Standard.Base.Data.Numbers.Integer|Standard.Base.Nothing.Nothing) | ||
| - rows_to_write self -> (Standard.Base.Data.Numbers.Integer|Standard.Base.Nothing.Nothing) | ||
| - Standard.Table.Rows_To_Read.Rows_To_Read.from that:Standard.Base.Nothing.Nothing -> Standard.Table.Rows_To_Read.Rows_To_Read |
There was a problem hiding this comment.
- will fix of Fully Qualified Names are not allowed in type signatures #8997 make the above line valid?
- the current reproducer in Allow fully qualified names in type signatures #12263 doesn't seem to check for
fromconversions yet - it'd be great if the FQN signatures used in this file were valid Enso code
- of source without the leading
-prefix
There was a problem hiding this comment.
It will be valid. It should not be a problem to add the from conversions as well. I think that once #8997 is merged, these markdown files will be valid Enso code, without the leading - prefixes.
Akirathan
force-pushed
the
wip/akirathan/api-check-std-table
branch
from
43be122 to
b29e0ec
Compare
github-actions
bot
added
the
-libs-API-change-Table
github-actions
bot
added
-libs-API-change-Microsoft
Akirathan
changed the title
Akirathan
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
|
The Standard Library API check job correctly detects that all the std libs should be checked. |
GregoryTravis
approved these changes
Feb 21, 2025
JaroslavTulach
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #12223 and #12326
Pull Request Description
Introduce API check for the rest of standard libraries.
It is enough to just generate the API signatures with something like:
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.