Add tests for Generic JDBC support for Postgres, SQLite #12300
+451
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
requested review from
jdunkerley,
radeusgd,
AdRiley and
marthasharkey
as code owners
radeusgd
reviewed
Feb 19, 2025
| @@ -1089,12 +1091,78 @@ add_data_link_specs suite_builder = | |||
| Audit_Spec.add_specs suite_builder prefix data_link_file.get database_pending=pending | |||
| Save_Connection_Data_Link.add_specs suite_builder prefix connection_details pending | |||
|
|
|||
| add_generic_jdbc_specs suite_builder = | |||
There was a problem hiding this comment.
I think the Postgres_Spec is so large, maybe we should split it overall.
But I guess first step could be to have this generic tests for postgres in a separate file? What do you think?
There was a problem hiding this comment.
Done -- I put them both in a JDBC/ subdir.
radeusgd
reviewed
Feb 19, 2025
Comment on lines
+119
to
+120
| r.at 0 . to_vector . should_equal [10, 20] | ||
| r.at 1 . to_vector . should_equal ['asdf', 'zxcv'] |
There was a problem hiding this comment.
Why are we not checking the column names anymore?
There was a problem hiding this comment.
Some backends are case-sensitive so there's no column name that will work across the three backends we're testing; I make sure to have name-based access in the backend-specific tests.
radeusgd
approved these changes
Feb 19, 2025
AdRiley
approved these changes
Feb 19, 2025
GregoryTravis
added
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have full support for these backends, generic JDBC use will be rare. But the drivers are already available, and we need tests for multiple backends.
The original tests are now in H2_Spec.enso.
Some features (catalogs, schemas) are only tested for H2. The behavior of these methods vary greatly between backends so it is not important to build tests for them for each backend.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.