Skip to content

Conversation

@kazcw
Copy link
Contributor

@kazcw kazcw commented Dec 8, 2025

Pull Request Description

For every Ident or PropertyAccess, there is an enclosing Call node, at the root of the tree of 0 or more App/NamedApp nodes containing the node. After this change, all method call sites (except methods invoked through binary-operator syntax) have corresponding Call nodes, and the nodes are ready to use.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@kazcw kazcw self-assigned this Dec 8, 2025
@kazcw kazcw added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Dec 9, 2025
Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving parser changes.

t = app.getLhs();
}
if (t instanceof Tree.Call call) {
t = call.getValue();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the intentions of call nodes seem to be good
  • now when I "get them"
  • let's try the approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Clean build required CI runners will be cleaned before and after this PR is built.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants