Transfer BoolStorage between dual JVMs off-heap
#14459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
AdRiley,
GregoryTravis,
hubertp and
jdunkerley
as code owners
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
changed the title
BoolStorage between dual JVMs off-heap
…sOfBoolStorage14449
3 tasks
jdunkerley
approved these changes
Dec 10, 2025
| ImmutableBitSet validityMap, | ||
| int size, | ||
| boolean negated, | ||
| ColumnStorage<?> other) { |
Member
There was a problem hiding this comment.
Suggested change
| ColumnStorage<?> other) { | |
| ColumnStorage<?> proxy) { |
to make it clear?
Member
Author
There was a problem hiding this comment.
If follows this pattern:
PS: I didn't notice this comment before integration.
| private static ColumnStorage<?> applyBoolStorage( | ||
| boolean keepValue, BoolStorage boolStorage, int checkedSize) { | ||
| BitSet values = boolStorage.getValues(); | ||
| BitSet values = boolStorage.getValues().cloneBitSet(); |
Member
There was a problem hiding this comment.
why do we need to clone here - I assume because it is an ImmutableBitSet now?
Member
Author
There was a problem hiding this comment.
- Yes, to get a
BitSetfromImmutableBitSetone callscloneBitSet()which does a clone/copy. - that way we can guarantee consistency of
ImmutableBitSetinstances - we'll see if such a change has a detrimental effect on the performance later
- and then we can think of optimizing these additional copyings
|
Jaroslav Tulach reports a new STANDUP for yesterday (2025-12-10): Progress: .
|
3 tasks
|
Jaroslav Tulach reports a new STANDUP for yesterday (2025-12-11): Progress: .
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
- addresses #13804 by enabling _dual JVM mode_ for `Standard.Microsoft` library - with the help of #14459 - and #14471 - and #13851 - and #14436 - we shall be ready to try the _dual JVM mode_ for real! - needs f63430e changes in `Environment.get` to work in _dual JVM mode_ - removes most of no longer necessary #14037 changes - the size of `enso` goes down by **60MB** to 344MB - to be verified by #14475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Builder.makeLocal#14449 discovers thatBoolStorageis often crossing the dual JVM boundaryaddressOfData()andaddressOfValidity()toBoolStorageto speed the transfer upChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,