-
Notifications
You must be signed in to change notification settings - Fork 334
Make Standard.Test pending field lazy
#14536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JaroslavTulach
wants to merge
10
commits into
develop
Choose a base branch
from
wip/jtulach/LazyPending14474
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+154
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GregoryTravis
approved these changes
Dec 23, 2025
jdunkerley
requested changes
Dec 24, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not move the Faker library. It is a useful tool for data creation.
And please restore it's export.
I'm also not convinced by making all the URI generation lazy. If it is necessary ok but feels like adding complexity to key test suites for little benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-libs-API-change-Test
Marks a PR that changes the public API of Standard.Test
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Standard.Snowflakein dual JVM mode #14474 showspendingfield evaluation lazyImportant Notes
suite_builder.group ... group_builder->body is invoked every time even if the group will be pendingChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,