Skip to content

Conversation

@JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Dec 23, 2025

Pull Request Description

Important Notes

  • suite_builder.group ... group_builder-> body is invoked every time even if the group will be pending
    • one needs to be careful to not access non-initialized values
    • however otherwise such a behavior is not incorrect
    • allows to enumerate all tests in all groups, even they are found pending then
    • the change in behavior needs fixes like 5e359c9

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Java,
  • Unit tests have been written where possible.

@github-actions github-actions bot added the -libs-API-change-Test Marks a PR that changes the public API of Standard.Test label Dec 23, 2025
@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Dec 23, 2025
@JaroslavTulach JaroslavTulach linked an issue Dec 23, 2025 that may be closed by this pull request
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not move the Faker library. It is a useful tool for data creation.

And please restore it's export.

I'm also not convinced by making all the URI generation lazy. If it is necessary ok but feels like adding complexity to key test suites for little benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-libs-API-change-Test Marks a PR that changes the public API of Standard.Test CI: Clean build required CI runners will be cleaned before and after this PR is built.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean Standard.Test API up

4 participants