-
Notifications
You must be signed in to change notification settings - Fork 334
Running Standard.Tableau in dual JVM mode #14607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| if schemas.distinct.length <= 1 then (Table_Viz_Data.GenericGrid [Table_Viz_Header.Link "Table" "Table" "read {{@Table}}"] [tables]) else | ||
| (Table_Viz_Data.GenericGrid [Table_Viz_Header.Label "Schema", Table_Viz_Header.Link "Table" "Table" "read {{@Table}} {{@Schema}}"] [schemas, tables]) | ||
|
|
||
| private wrap_io_exception (file : File | Nothing) io_exception = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Another copy of IOException handling code in 2f37d20
- taken from https://github.com/enso-org/enso/pull/14568/files#r2664926100
- Proper fix: Avoid fragile Java exception to Enso error/panic conversions #14601
b96b610 to
d8730c9
Compare
|
Jaroslav Tulach reports a new STANDUP for yesterday (2026-01-11): Progress: .
|
|
There two failures in Write Tables:
|
| if (v.getMetaObject() instanceof Value meta) { | ||
| type = meta.getMetaQualifiedName(); | ||
| } | ||
| if ("java.math.BigDecimal".equals(type)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Another case of
BigDecimaltraveling between dual JVMs - just like Run
Standard.Snowflakein dual JVM mode #14474 (comment)
| case LocalDate ld -> inserter.add(ld); | ||
| case LocalTime lt -> inserter.add(lt); | ||
| case ZonedDateTime zdt -> inserter.add(zdt); | ||
| case BigDecimal bd -> inserter.add(bd); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is different than the classical switch over StorageType. That one can be fixed by making the StorageType local. Is there any reason why this code has to be different and not follow the typical switch (storageType) pattern?
Akirathan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to also delete std-bits/tableau/**/resources/**/native directory with NI config files.
|
Jaroslav Tulach reports a new STANDUP for yesterday (2026-01-12): Progress: .
|
|
Jaroslav Tulach reports a new STANDUP for yesterday (2026-01-13): Progress: .
|
- #14607 reveals a problem when running ```ruby from Standard.Base import all from Standard.Table import all from Standard.Tableau import all main = node1 = Data.read '/tmp/x.hyper' node2 = node1.read 'Extract' node3 = node2.set (expr 'year([Date])') "Year" node3.get "Year" . to_vector ``` in _dual JVM_ (mock) mode: ``` sbt:enso> runEngineDistribution --vm.D=polyglot.enso.classLoading=Standard.Tableau:guest,hosted --run hyper.enso Error:Argument_Mismatch Unsupported type: class com.oracle.truffle.polyglot.PolyglotMapAndFunction (expected date/time type). ``` - builds upon #14309 - and upon #14471
Pull Request Description
Standard.AWSin Dual JVM mode #14568Standard.Snowflakein dual JVM mode #14474Standard.Googlein dual JVM mode #14040ensoimageChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,