Storing LocalDate in off-heap IntBuffer
#14652
Merged
+154
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
GregoryTravis,
hubertp and
jdunkerley
as code owners
JaroslavTulach
added
the
CI: No changelog needed
jdunkerley
approved these changes
Jan 19, 2026
Member
jdunkerley
left a comment
jdunkerley
left a comment
There was a problem hiding this comment.
A few nits but looks clearer than inside the Typed ones
std-bits/table/src/main/java/org/enso/table/data/column/builder/Builder.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/data/column/builder/DateBuilder.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public Builder retypeTo(StorageType<?> type) { | ||
| if (allowDateToDateTimeConversion && Objects.equals(type, DateTimeType.INSTANCE)) { |
Member
There was a problem hiding this comment.
Nit but would invert the if and throw with the body not surrounded anymore
Member
Author
There was a problem hiding this comment.
body not surrounded anymore
- that's a bit less FP style
- but I often prefer it as well
std-bits/table/src/main/java/org/enso/table/data/column/builder/DateBuilder.java
Show resolved
Hide resolved
hubertp
approved these changes
Jan 19, 2026
Co-authored-by: James Dunkerley <[email protected]>
Co-authored-by: James Dunkerley <[email protected]>
JaroslavTulach
force-pushed
the
wip/jtulach/TimeOfDayArrowStorage
branch
from
9347dca to
9e23b5e
Compare
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
LocalDateacross JVMs #14632DateBuilderto have its ownDateStorageTypedStoragewith its inefficient heap based dataLocalData.toEpochDayintoIntBufferin expected Arrow formatImportant Notes
NumberBuildertoValidityBuilderBitMapChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,