[auth] refactor(icons): refine SVG code integrity and icon registry #8320
+645
−4,719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied a unified XML structure to files in the 'custom-icons' directory to ensure codebase consistency using SVGOMG. - Standardize internal code formatting and attribute usage for uniformity. - Sanitize files by removing inconsistent editor artifacts (Adobe Illustrator, Inkscape namespaces). - Clean up XML doctypes and comments to maintain code hygiene. - Preserved visual fidelity with no visible quality loss. - Result: Achieved a cleaner codebase with ~21.09% (310KB) size reduction as a secondary benefit. Refined 'custom-icons.json' registry: - Sorted all entries alphabetically for better maintainability. - Removed duplicate 'tencent cloud' entry. - Fixed syntax error in 'Animal Crossing' slug key.
sayimburak
changed the title
Contributor
|
Hey @sayimburak, this is a big PR with lot of changes and it is hard for us to review. Could you make simple smaller pr. |
Contributor
Author
|
Agreed. I was standardizing the logos (a bit of OCD). I realize it made the PR hard to review. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied a unified XML structure to files in the 'custom-icons' directory to ensure codebase consistency using SVGOMG.
Refined 'custom-icons.json' registry: