[mob][locker] Allow account creation #8483
Conversation
Co-Authored-By: Claude <[email protected]>
…nd improve UI consistency
…ith improved theming and layout adjustments
…layout adjustments
… and maintainability
…Indicator integration
…ut and add dots_indicator dependency
…and user service pages
…ved error handling
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| await showBaseBottomSheet( | ||
| context, | ||
| headerSpacing: 20, | ||
| title: context.strings.signOutFromOtherDevices, |
There was a problem hiding this comment.
The new showBaseBottomSheet call uses the default isDismissible: true (see base_bottom_sheet.dart), while logOutFromOther is initialized to true. If the user taps outside the sheet or closes it without choosing, this function still returns true, and _updatePassword will log out other sessions without explicit consent. Consider making the sheet non‑dismissible or returning false on dismiss to avoid unintended logouts.
Useful? React with 👍 / 👎.
…-out from other devices
…hase from project.pbxproj
mobile/apps/auth/pubspec.yaml
Outdated
| git: | ||
| url: https://github.com/ente-io/ente.git |
There was a problem hiding this comment.
why we are adding dependency on commit ? it will close clone the whole repo for building.
There was a problem hiding this comment.
This is done to avoid breaking for auth as the redesign is done on the packages/account which is used for auth as well. So I pinned these packages to main
There was a problem hiding this comment.
This feels like bad design as it breaks the primary purpose of having common packages. It completely defeats the purpose of having common packages.
Let's discuss this in person
| _logger.severe(e, s); | ||
| if (e.response?.statusCode == 401) { | ||
| _logger.info("Session expired in trash sync, triggering logout"); | ||
| Bus.instance.fire(TriggerLogoutEvent()); | ||
| throw UnauthorizedError(); | ||
| } | ||
| rethrow; |
There was a problem hiding this comment.
Why is this require here? Ideally, during collections diff sync itself or remote sync we should get this exception and handle it at that place instead of doing this at every api place
Session expiry is already handled centrally in CollectionApiClient. Co-Authored-By: Claude <[email protected]>
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
## Description ## Tests
Let SVG use natural dimensions instead of fixed height: 24 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Description
Tests