Skip to content

Conversation

@AswinAsok
Copy link
Contributor

@AswinAsok AswinAsok commented Jan 7, 2026

Description

Albums now are being downloaded as a group of zip files, unless it's a single file.

image image image

@AswinAsok AswinAsok marked this pull request as draft January 7, 2026 06:19
@socket-security
Copy link

socket-security bot commented Jan 7, 2026

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad53435a89

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@AswinAsok AswinAsok marked this pull request as ready for review January 8, 2026 08:38
@anandbaburajan
Copy link
Member

  • Lint is failing
  • Current naming is: Himalayas On Cycle - 1K KM to Leh (17 files)-4. Let's do Himalayas On Cycle - 1K KM to Leh (Part 4 - 17 files) and the first one should have "Part 1" as well
  • I tried download two albums, and in both of them, a few files failed. I clicked the retry button in both of them and the failed files in both of them successfully downloaded. Which makes me curious, why were the files failing at all? I briefly checked those few files, and didn't find anything weird about them. Note that the two albums were large (200+ photos)
  • I tried one of those albums again and didn't get any failed files :D
  • When clicking download on an album, the notification/toast says "Downloading ... 34/232 files" but since nothing is being downloaded until the zip is ready, it might be confusing. We could say "Processing" maybe? Not sure

@anandbaburajan anandbaburajan merged commit 42bd350 into ente-io:main Jan 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants