Turn RegistryEntries into an ABC and create subclasses for frozen and non-frozen cases.
#738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Jan 14, 2025
junkmd
force-pushed
the
interp_frozen_register
branch
from
841969f to
ac1f426
Compare
junkmd
force-pushed
the
interp_frozen_register
branch
from
ac1f426 to
cfb8188
Compare
junkmd
force-pushed
the
interp_frozen_register
branch
from
cfb8188 to
4b817b8
Compare
junkmd
force-pushed
the
interp_frozen_register
branch
from
4b817b8 to
d3154e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality of creating entries for both frozen and interpreter (non-frozen) COM servers within
RegistryEntriescoexists with complex conditional branching. This may be a reason for the lack of clarity in COM server registration.To address this complexity, I separate the implementation into distinct subclasses for frozen and interpreter servers. Common entries are refactored into top-level functions to adhere to the DRY principle.