Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WinDLL instead of windll #752

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Use WinDLL instead of windll #752

merged 3 commits into from
Jan 19, 2025

Conversation

moi15moi
Copy link
Contributor

I simply added the 3 commits you talked here: #735 (comment)

@junkmd
Copy link
Collaborator

junkmd commented Jan 19, 2025

Thanks.

Please address only the formatting issues.

@moi15moi moi15moi force-pushed the Use-WinDLL-instead-of-windll branch from 0060536 to 78154b9 Compare January 19, 2025 04:08
@junkmd junkmd added this to the 1.4.10 milestone Jan 19, 2025
junkmd
junkmd approved these changes Jan 19, 2025
View reviewed changes
Copy link
Collaborator

@junkmd junkmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@junkmd junkmd merged commit a2fc2c5 into enthought:main Jan 19, 2025
50 checks passed
@junkmd junkmd linked an issue Jan 19, 2025 that may be closed by this pull request
Avoid modifying shared DLL objects #735
Open
@moi15moi moi15moi deleted the Use-WinDLL-instead-of-windll branch January 19, 2025 04:58
@junkmd junkmd removed a link to an issue Jan 26, 2025
Avoid modifying shared DLL objects #735
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junkmd junkmd junkmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.10
Development

Successfully merging this pull request may close these issues.
2 participants
@moi15moi @junkmd