Add alternate names with µ for micro instead of u
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the old names around, so no code should break.
|
Please could you add some tests? For example, a test that 'µf' has the appropriate relationship to 'f' would be useful. |
mdickinson
reviewed
Jul 2, 2021
| @@ -71,7 +71,7 @@ | |||
|
|
|||
| m = meter | |||
| nm = nanometer | |||
| um = micrometer | |||
| µm = um = micrometer | |||
There was a problem hiding this comment.
Probably worth adding a test that both µm (using MICRO SIGN) and μm (using GREEK SMALL LETTER MU) are parsed correctly with this definition. They are right now, but that could change if we move away from using eval at some point in the future.
There was a problem hiding this comment.
FWIW, and somewhat surprisingly, Unicode TR 25 says that GREEK SMALL LETTER MU is the preferred character here. (See section 2.5 of http://www.unicode.org/reports/tr25/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes several labels that were using
ufor "micro".This keeps the old names around, so no code should break.
Fixes #135.