-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional
trait type
#1786
base: main
Are you sure you want to change the base?
Optional
trait type
#1786
Conversation
Sorry if I'm missing something obvious, I'm not sure I can link the error in tests to these changes. Additionally the failing test passes for me on my Ubuntu-on-WSL-on-Windows. Update: from here I'm guessing it's an external (to this MR) issue |
Sorry, @k2bd: there hasn't been much in the way of spare cycles for Traits maintenance recently. Thank you for the PR - I do hope to get to it soon. Yes, there's at least one unrelated issue here, related to a new release of PySide 6. I'll investigate. |
@mdickinson no worries at all! I just got around to looking into the error yesterday after seeing it wasn't something immediately apparent at the time, and didn't want to keep anyone waiting too long if it was a subtle problem with what I wrote! At the time, I couldn't find other workflow failures I had access to to see it was likely independent |
I've opened #1787 for the current crop of CI failures. This looks like a TraitsUI + PySide 6.7.0 issue. |
eda60d4
to
6c58d95
Compare
6c58d95
to
13fcc59
Compare
Closes #1298
This PR:
Optional
trait type as a shorthand forUnion(None, ...)
Union
to refer to subclass names, e.g.Optional
(let me know if this is controversial and I can change!)Constant
,Union
, andOptional
demonstrating behaviour discussed inConstant
constraint not enforced inUnion
#1784, some of these may also be controversial and I can remove/alter them if soChecklist
docs/source/traits_api_reference
)docs/source/traits_user_manual
)