Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a misuse of the unittest.expectedFailure decorator. #346

Merged
merged 2 commits into from
Jan 16, 2017
Merged

Fix a misuse of the unittest.expectedFailure decorator. #346

merged 2 commits into from
Jan 16, 2017

Conversation

mdickinson
Copy link
Member

Besides being inappropriate here, this expectedFailure decorator also results in the following odd-looking output from our test suite, since nose doesn't understand it:

/opt/python/2.7.9/lib/python2.7/unittest/case.py:340: RuntimeWarning: TestResult has no addExpectedFailure method, reporting as passes

@mdickinson
Copy link
Member Author

Self-merging.

@mdickinson mdickinson merged commit 1f18668 into master Jan 16, 2017
@mdickinson mdickinson deleted the fix/expected-failure-misuse branch January 16, 2017 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdickinson