Undo changes to library name and gemspec #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g. ActiveSupport's) versions if they are already in-place
it should be "true" when required.
auto-submitting javascript off body attribute and into a timeout to verify availability of form in the DOM.
…nitialize it at a smarter time.
auto-submitting javascript off body attribute and into a timeout to verify availability of form in the DOM.
…setup_needed tests to verify setup_url in response.
…nder my install of OSX 10.6)
…d version computation comment
…id transaction in progress form to be sure we are autosubmitting the correct form
added 30 commits
February 29, 2012 09:28
…ng URL fragments for Identifier Recycling. The local_id is a canonical_id at the OP when the local_id is an iname at the RP. Matching claimed_ids instead of local_ids resolves the incompatibility. (reverse-merged from commit 4a17c08)
Conflicts: lib/openid.rb lib/openid/store/memcache.rb lib/openid/util.rb ruby-openid.gemspec test/test_accept.rb test/test_association.rb test/test_associationmanager.rb Reverted Mike Mell's changes to memcached store in favor of agoragames memcached Dalli changes.
…ined in lib/openid/version.rb.
…efactor test iname into constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for merging all the pull requests and updating the gem. One problem with the most recent changes to rename the gem is that it makes the gem no longer a drop-in replacement for the original gem. Libraries such as openauth which have gem requirements on ruby-openid cannot be used with your gem.