Skip to content

refactor: move MAX_ISSUE_ID to gittensor/constants.py and use it on the validator side #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ebios-star wants to merge 1 commit into from
Closed

refactor: move MAX_ISSUE_ID to gittensor/constants.py and use it on the validator side #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions gittensor/cli/issue_commands/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from rich.console import Console

from gittensor.cli.issue_commands.tables import build_pr_table
from gittensor.constants import NETWORK_MAP
from gittensor.constants import MAX_ISSUE_ID, NETWORK_MAP
from gittensor.validator.issue_competitions.storage_utils import (
compute_ink5_lazy_key,
decode_issue_from_storage,
Expand All @@ -38,7 +38,6 @@
ALPHA_RAW_UNIT = 10**ALPHA_DECIMALS
MIN_BOUNTY_ALPHA = 10
MAX_BOUNTY_ALPHA = 100_000_000
MAX_ISSUE_ID = 1_000_000
MAX_ISSUE_NUMBER = 2**32 - 1
REPO_PATTERN = re.compile(r'^[a-zA-Z0-9._-]+/[a-zA-Z0-9._-]+$')
GITHUB_API_TIMEOUT = 10
Expand Down
1 change: 1 addition & 0 deletions gittensor/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,3 +215,4 @@
CONTRACT_ADDRESS = '5FWNdk8YNtNcHKrAx2krqenFrFAZG7vmsd2XN2isJSew3MrD'
ISSUES_TREASURY_UID = 111 # UID of the smart contract neuron, if set to RECYCLE_UID then it's disabled
ISSUES_TREASURY_EMISSION_SHARE = 0.15 # % of emissions allocated to funding issues treasury
MAX_ISSUE_ID = 1_000_000 # sanity-check upper bound for any real deployment
4 changes: 2 additions & 2 deletions gittensor/validator/issue_competitions/contract_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from substrateinterface import Keypair
from substrateinterface.exceptions import ExtrinsicNotFound

from gittensor.constants import MAX_ISSUE_ID
from gittensor.validator.issue_competitions.storage_utils import (
compute_ink5_lazy_key,
decode_issue_from_storage,
Expand Down Expand Up @@ -191,8 +192,7 @@ def get_issues_by_status(self, status: IssueStatus) -> List[ContractIssue]:
if next_issue_id <= 1:
return []

MAX_REASONABLE_ISSUE_ID = 1_000_000
if next_issue_id > MAX_REASONABLE_ISSUE_ID:
if next_issue_id > MAX_ISSUE_ID:
bt.logging.warning(f'next_issue_id ({next_issue_id}) unreasonably large')
return []

Expand Down
Loading