Skip to content

fix: require completed closure for bounty solver lookup - #1057

Closed
WT-WSL wants to merge 1 commit into
entrius:testfrom
WT-WSL:fix/issue-979-completed-closure
Closed

fix: require completed closure for bounty solver lookup#1057
WT-WSL wants to merge 1 commit into
entrius:testfrom
WT-WSL:fix/issue-979-completed-closure

Conversation

@WT-WSL

@WT-WSL WT-WSL commented May 7, 2026

Copy link
Copy Markdown

Summary

  • Require GitHub issue state_reason to be completed before issue-bounty solver lookup runs.
  • Default-deny non-completed, null, or missing closure reasons so those closures cannot produce vote_solution().
  • Update GitHub API helper tests to use the session-backed request path and cover non-completed closure reasons.

Validation

  • python3 -m py_compile gittensor/utils/github_api_tools.py tests/utils/test_github_api_tools.py tests/validator/test_issue_competitions_forward.py
  • git diff --check
  • Not run: pytest (pytest, uv, and pip are unavailable in this environment).

Close: #979

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 7, 2026
@anderdc

anderdc commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Duplicate of #980 which is better scoped/implemented. Closing.

@anderdc anderdc closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Issue bounties can vote solutions for non-completed GitHub closures

2 participants