fix: use last:50 instead of first:50 for solver cross-reference lookup (#1017) - #1126
Closed
alpurkan17 wants to merge 2 commits into
Closed
fix: use last:50 instead of first:50 for solver cross-reference lookup (#1017)#1126alpurkan17 wants to merge 2 commits into
alpurkan17 wants to merge 2 commits into
Conversation
added 2 commits
May 9, 2026 03:11
Collaborator
|
Duplicate of #1018 which is better scoped/implemented. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
first:50tolast:50in GraphQL query for solver repository lookupRoot Cause
Solver cross-reference lookup uses
first:50to fetch PRs, which returns the OLDEST PRs first. The solver's most recent PR (the one affecting current scoring) is likely at the end of the list — often beyond the 50-item window, so it's missed entirely.Impact
Solver cross-reference resolution misses recent PRs, leading to stale solver data and incorrect scoring of solver contributions.
Why
Solvers are scored on recent PRs.
first:50returns oldest PRs — wrong direction for relevanceRelated Issues
Fixes #1017
Test plan
How to verify
last:50notfirst:50Edge cases considered
Post-merge verification