feat: show GitHub username after PAT validation (#1004) - #1133
Closed
alpurkan17 wants to merge 1 commit into
Closed
Conversation
Extract the login field from the GitHub /user API response and display it in the success message, so miners know which identity their PAT registered.
alpurkan17
pushed a commit
to alpurkan17/gittensor
that referenced
this pull request
May 9, 2026
Collaborator
|
Duplicate of #1005 which has been merged. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Token for @username: validinstead of justToken: validRoot Cause
After
validate_pat_token()confirms a token is valid, it returns only boolean success. The miner doesn't know WHICH GitHub account the token belongs to — important when multiple tokens are configured.Impact
Miners with multiple PATs can't verify which token maps to which GitHub account. Debugging token issues requires trial-and-error.
Why
Miners running multiple accounts need clear token-to-account mapping
Related Issues
Fixes #1004
Test plan
Live verification
gitt miner validate-patnow showsToken for @alpurkan17: validHow to verify
gitt miner validate-patwith a valid PAT@your-usernamein the outputEdge cases considered
Post-merge verification