Skip to content

fix: filter cross-repo closing references in PR timeline query (#1041) - #1148

Closed
alpurkan17 wants to merge 0 commit into
entrius:testfrom
alpurkan17:fix/1041-cross-repo-timeline-closing
Closed

fix: filter cross-repo closing references in PR timeline query (#1041)#1148
alpurkan17 wants to merge 0 commit into
entrius:testfrom
alpurkan17:fix/1041-cross-repo-timeline-closing

Conversation

@alpurkan17

Copy link
Copy Markdown
Contributor

Summary

_PR_TIMELINE_QUERY's closingIssuesReferences fragment emits only nodes { number } without repository qualification. When a PR closes a same-numbered issue in a different repository, find_solver_from_cross_references matches by issue number alone and can credit the wrong solver.

Fix mirrors the approach from PR #1020 on the timeline query:

  • Add repository { nameWithOwner } to the closingIssuesReferences fragment in _PR_TIMELINE_QUERY
  • Filter closing numbers by matching repository name in the parser

Validation

  • uv run ruff check — clean
  • uv run ruff format --check — clean
  • uv run pyright — 0 errors

Closes #1041

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 11, 2026
@alpurkan17

Copy link
Copy Markdown
Contributor Author

Hi maintainers, this is a small 1-file fix (+11/-2) for cross-repo closing references in PR timeline query (fixes #1041). Quick review would be appreciated — thanks!

@alpurkan17 alpurkan17 closed this May 11, 2026
@alpurkan17
alpurkan17 force-pushed the fix/1041-cross-repo-timeline-closing branch from f437532 to bb9eb04 Compare May 11, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

1 participant