fix: filter cross-repo closing references in PR timeline query (#1041) - #1148
Closed
alpurkan17 wants to merge 0 commit into
Closed
fix: filter cross-repo closing references in PR timeline query (#1041)#1148alpurkan17 wants to merge 0 commit into
alpurkan17 wants to merge 0 commit into
Conversation
Contributor
Author
|
Hi maintainers, this is a small 1-file fix (+11/-2) for cross-repo closing references in PR timeline query (fixes #1041). Quick review would be appreciated — thanks! |
alpurkan17
force-pushed
the
fix/1041-cross-repo-timeline-closing
branch
from
May 11, 2026 19:14
f437532 to
bb9eb04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_PR_TIMELINE_QUERY'sclosingIssuesReferencesfragment emits onlynodes { number }without repository qualification. When a PR closes a same-numbered issue in a different repository,find_solver_from_cross_referencesmatches by issue number alone and can credit the wrong solver.Fix mirrors the approach from PR #1020 on the timeline query:
repository { nameWithOwner }to theclosingIssuesReferencesfragment in_PR_TIMELINE_QUERYValidation
uv run ruff check— cleanuv run ruff format --check— cleanuv run pyright— 0 errorsCloses #1041