ci(sparkinfer): conformance-check a published tag without republishing it - #1729
Merged
Conversation
…g it The conformance job only needs an image tag — serving_conformance_on_lium.sh pulls entrius/sparkinfer:<tag> from Docker Hub itself. It depended on the build job purely for the digest, so re-measuring an already-blessed image meant rebuilding and overwriting its tag with a new digest for identical content. `build` (default true, unchanged) can now be unchecked: the image job is skipped, and conformance resolves ref/tag from the inputs or the loadout and reads the digest from the registry. Blessing a new runtime is unaffected; re-running conformance on the blessed one no longer republishes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/serving_conformance_on_lium.shtakes an image tag and pulls it from Docker Hub itself — it never needed the build job. Theconformancejob depended onimageonly forsteps.build.outputs.digest, so re-measuring an already-published image meant rebuilding it and overwriting its tag with a new digest for byte-identical content.Adds a
buildinput (defaulttrue, so blessing a new runtime is unchanged). Unchecked:imagejob is skipped;conformancestill runs, resolvesref/tagfrom the inputs orserving_loadout.json, and reads the digest from the registry (hub.docker.com/v2/repositories/entrius/sparkinfer/tags/<tag>), failing clearly if the tag isn't published;Why now:
runtime_imagehas no digest and the loadout has noattest.reference_wall_ms, both of which only a conformance run can write. The blessedentrius/sparkinfer:7498736needs no rebuild — the attest sidecar was added in #1722 and removed in #1727, and only ever shipped in the7498736-attest1tag, so the 8/27-built7498736already matches today's Dockerfile (the diff is two comments andEXPOSE). This lets us measure it without touching it.