perf(github-api): add optional session parameter to GraphQL utility functions - #697
Closed
mkdev5 wants to merge 2 commits into
Closed
perf(github-api): add optional session parameter to GraphQL utility functions#697mkdev5 wants to merge 2 commits into
mkdev5 wants to merge 2 commits into
Conversation
mkdev5
changed the title
The scan_closed_issues path issues hundreds of REST pagination calls and up to 1500 GraphQL solver lookups per validator round. Each call went through the top-level requests.get/post API, which creates and closes a fresh Session per call, so every request paid a new TCP and TLS handshake to api.github.com. Wrap the scan in a single requests.Session() and thread it through _fetch_closed_issues and find_solver_from_cross_references (via execute_graphql_query and _search_issue_referencing_prs_graphql) so urllib3 keeps the underlying connection pool alive for the whole round. All helpers accept an optional session kwarg that defaults to None, preserving existing callers and tests.
mkdev5
force-pushed
the
fix/repo-scan-session-pooling
branch
from
April 24, 2026 09:36
a3435f8 to
99dc5ee
Compare
…on-pooling # Conflicts: # gittensor/validator/issue_discovery/repo_scan.py # tests/validator/test_issue_discovery_repo_scan.py # tests/validator/test_repo_scan.py
mkdev5
changed the title
Collaborator
|
Duplicate of #687 which is better scoped/implemented. Closing. |
Collaborator
|
Closing — current diff doesn't address #696. Please open a fresh issue + PR if the session-pooling change is still wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional
session: Optional[requests.Session] = Noneparameter toexecute_graphql_query,_search_issue_referencing_prs_graphql, andfind_solver_from_cross_referencesingittensor/utils/github_api_tools.py.When a caller supplies a pooled
requests.Session,execute_graphql_queryusessession.post(...)instead of the top-levelrequests.post(...), allowing urllib3 to reuse the underlying TCP + TLS connection across calls. The defaultNonepreserves all existing callers — no behavioural or scoring changes.Related Issues
Closes #696
Type of Change
Testing
Checklist