Skip to content

refactor: extract duplicate backoff delay calc into _backoff_seconds helper #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anderdc merged 2 commits into from
Apr 30, 2026
Merged

refactor: extract duplicate backoff delay calc into _backoff_seconds helper #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
081e0b1
refactor: move backoff_seconds to utils.py and use it in mirror/clien…
wdeveloper16 Apr 29, 2026
b42583e
Merge branch 'test' into refactor/extract-backoff-seconds-helper
anderdc Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions gittensor/utils/github_api_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from math import ceil
from typing import TYPE_CHECKING, Any, Dict, Iterator, List, Optional

from gittensor.utils.utils import parse_repo_name
from gittensor.utils.utils import backoff_seconds, parse_repo_name

if TYPE_CHECKING:
from gittensor.classes import FileChange as FileChangeType
Expand Down Expand Up @@ -299,7 +299,7 @@ def get_merge_base_sha(repository: str, base_sha: str, head_sha: str, token: str
return None

if attempt < max_attempts - 1:
backoff_delay = min(5 * (2 ** (attempt)), 30)
backoff_delay = backoff_seconds(attempt)
bt.logging.warning(
f'Compare API for {repository} failed with status {response.status_code} '
f'(attempt {attempt + 1}/{max_attempts}), retrying in {backoff_delay}s...'
Expand All @@ -308,7 +308,7 @@ def get_merge_base_sha(repository: str, base_sha: str, head_sha: str, token: str

except requests.exceptions.RequestException as e:
if attempt < max_attempts - 1:
backoff_delay = min(5 * (2 ** (attempt)), 30)
backoff_delay = backoff_seconds(attempt)
bt.logging.warning(
f'Compare API error for {repository} (attempt {attempt + 1}/{max_attempts}): {e}, '
f'retrying in {backoff_delay}s...'
Expand Down Expand Up @@ -377,7 +377,7 @@ def get_pull_request_file_changes(repository: str, pr_number: int, token: str) -
attempt += 1

if attempt < max_attempts:
backoff_delay = min(5 * (2 ** (attempt - 1)), 30)
backoff_delay = backoff_seconds(attempt - 1)
bt.logging.warning(
f'File changes request for PR #{pr_number} in {repository} failed with {last_error} '
f'(attempt {attempt}/{max_attempts}), per_page={per_page}, retrying in {backoff_delay}s...'
Expand All @@ -391,7 +391,7 @@ def get_pull_request_file_changes(repository: str, pr_number: int, token: str) -
attempt += 1

if attempt < max_attempts:
backoff_delay = min(5 * (2 ** (attempt - 1)), 30)
backoff_delay = backoff_seconds(attempt - 1)
bt.logging.warning(
f'File changes request error for PR #{pr_number} in {repository} '
f'(attempt {attempt}/{max_attempts}): {e}, retrying in {backoff_delay}s...'
Expand Down Expand Up @@ -575,7 +575,7 @@ def execute_graphql_query(

# Retry on failure
if attempt < (max_attempts - 1):
backoff_delay = min(5 * (2**attempt), 30) # max of 30 second wait between retries
backoff_delay = backoff_seconds(attempt)
bt.logging.warning(
f'GraphQL request failed with status {response.status_code} '
f'(attempt {attempt + 1}/{max_attempts}), retrying in {backoff_delay}s...'
Expand All @@ -589,7 +589,7 @@ def execute_graphql_query(

except requests.exceptions.RequestException as e:
if attempt < (max_attempts - 1):
backoff_delay = min(5 * (2**attempt), 30)
backoff_delay = backoff_seconds(attempt)
bt.logging.warning(
f'GraphQL request exception (attempt {attempt + 1}/{max_attempts}), '
f'retrying in {backoff_delay}s: {e}'
Expand Down Expand Up @@ -666,7 +666,7 @@ def get_github_graphql_query(
if attempt < (max_attempts - 1):
old_limit = limit
limit = max(limit // 2, 10)
backoff_delay = min(2 * (2**attempt), 15)
backoff_delay = backoff_seconds(attempt, base=2, cap=15)
bt.logging.warning(
f'GraphQL RESOURCE_LIMITS_EXCEEDED (attempt {attempt + 1}/{max_attempts}), '
f'page size {old_limit} -> {limit}, retrying in {backoff_delay}s...'
Expand All @@ -683,7 +683,7 @@ def get_github_graphql_query(

# HTTP error - log and retry
if attempt < (max_attempts - 1):
backoff_delay = min(5 * (2**attempt), 30)
backoff_delay = backoff_seconds(attempt)
if response.status_code in (502, 503, 504):
limit = max(limit // 2, 10)
bt.logging.warning(
Expand All @@ -703,7 +703,7 @@ def get_github_graphql_query(

except requests.exceptions.RequestException as e:
if attempt < (max_attempts - 1):
backoff_delay = min(5 * (2**attempt), 30)
backoff_delay = backoff_seconds(attempt)
bt.logging.warning(
f'GraphQL request connection error (attempt {attempt + 1}/{max_attempts}): {e}, retrying in {backoff_delay}s...'
)
Expand Down
5 changes: 3 additions & 2 deletions gittensor/utils/mirror/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
MirrorPullRequestFilesResponse,
MirrorPullRequestsResponse,
)
from gittensor.utils.utils import backoff_seconds


class MirrorRequestError(RuntimeError):
Expand Down Expand Up @@ -103,7 +104,7 @@ def _get(self, path: str, params: Optional[dict] = None) -> dict:
except requests.RequestException as e:
last_error = f'request exception: {e}'
if attempt < self.max_attempts - 1:
backoff = min(5 * (2**attempt), 30)
backoff = backoff_seconds(attempt)
bt.logging.warning(
f'Mirror GET {path} raised {e} '
f'(attempt {attempt + 1}/{self.max_attempts}), retrying in {backoff}s...'
Expand All @@ -120,7 +121,7 @@ def _get(self, path: str, params: Optional[dict] = None) -> dict:

last_error = f'status {response.status_code}: {response.text[:200]}'
if attempt < self.max_attempts - 1:
backoff = min(5 * (2**attempt), 30)
backoff = backoff_seconds(attempt)
bt.logging.warning(
f'Mirror GET {path} failed ({last_error}) '
f'(attempt {attempt + 1}/{self.max_attempts}), retrying in {backoff}s...'
Expand Down
4 changes: 4 additions & 0 deletions gittensor/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
from typing import Dict


def backoff_seconds(attempt: int, base: int = 5, cap: int = 30) -> int:
return min(base * (2**attempt), cap)


def parse_repo_name(repo_data: Dict):
"""Normalizes and converts repository name from dict"""
return f'{repo_data["owner"]["login"]}/{repo_data["name"]}'.lower()
Expand Down
Loading