fix: alert on mirror service outage instead of silently zeroing scores - #820
Closed
wdeveloper16 wants to merge 2 commits into
Closed
fix: alert on mirror service outage instead of silently zeroing scores#820wdeveloper16 wants to merge 2 commits into
wdeveloper16 wants to merge 2 commits into
Conversation
wdeveloper16
force-pushed
the
fix/mirror-outage-alerting
branch
9 times, most recently
from
April 29, 2026 15:54
a4a0681 to
2486936
Compare
wdeveloper16
force-pushed
the
fix/mirror-outage-alerting
branch
from
April 29, 2026 17:52
2486936 to
853427e
Compare
Collaborator
|
Needless logging change. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #796. When
mirror.gittensor.iois unavailable, fetch failures were either logged atWARNINGlevel (issue discovery) or without scoring-impact context (OSS path), making it impossible to distinguish a service outage from isolated miner failures by watching error logs.WARNING→ERROR(consistent with OSS path severity)run_mirror_issue_discovery: emitsERRORwhen ≥50% of eligible miners fail andtotal_eligible >= 5(the guard suppresses false positives in small/dev environments)No behaviour changes
Scoring logic is untouched — this is purely observability. All 51 existing tests continue to pass.
Test plan
uv run --with pytest pytest tests/validator/oss_contributions/mirror/test_load.py tests/validator/issue_discovery/test_mirror_scan.py -v→ 51 passed