Skip to content

fix: detect PascalCase compiled-language tests and root-level conftest.py #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anderdc merged 3 commits into from
May 5, 2026
Merged

fix: detect PascalCase compiled-language tests and root-level conftest.py #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4ba4ee
fix: detect PascalCase compiled-language tests and root-level conftes…
polyjeff529 Apr 30, 2026
eda8546
fix: scope is_test_file to two pattern-list additions per #874 review
polyjeff529 May 5, 2026
d0b9c84
Merge branch 'test' into fix/is-test-file-pascalcase-and-rootlevel-co…
anderdc May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gittensor/classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ def is_test_file(self) -> bool:
r'(^|/)androidtest[a-z]*/',
r'(^|/)integrationtest/',
r'(^|/)spec/',
r'\.tests?/', # .NET MyProject.Tests/FooTests.cs
]
if any(re.search(pattern, filename_lower) for pattern in test_dir_patterns):
return True
Expand All @@ -98,6 +99,7 @@ def is_test_file(self) -> bool:
r'\.spec\.[^.]+$',
r'^test\.[^.]+$',
r'^tests\.[^.]+$',
r'^conftest\.py$',
]

return any(re.search(pattern, basename) for pattern in test_patterns)
Expand Down
24 changes: 24 additions & 0 deletions tests/test_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,30 @@ def test_is_test_file_preserves_existing_test_conventions():
assert _file_change('src/foo/bar.py').is_test_file() is False


@pytest.mark.parametrize(
'filename',
[
'src/MyProject.Tests/AccountServiceTests.cs',
'src/MyProject.Tests/AccountServiceTest.cs',
],
)
def test_is_test_file_detects_dotnet_dotted_tests_directory(filename):
assert _file_change(filename).is_test_file() is True


@pytest.mark.parametrize(
'filename',
[
'conftest.py',
'tests/conftest.py',
'project/conftest.py',
'project/sub/package/conftest.py',
],
)
def test_is_test_file_detects_conftest_at_any_depth(filename):
assert _file_change(filename).is_test_file() is True


def test_pull_request_handles_deleted_label_event():
pr_data = {
'number': 42,
Expand Down
Loading