refactor: use GITHUB_HTTP_TIMEOUT_SECONDS at the three remaining timeout=15 sites - #942
Closed
ebios-star wants to merge 1 commit into
Closed
Conversation
…out=15 sites `gittensor/utils/github_api_tools.py` already imports `GITHUB_HTTP_TIMEOUT_SECONDS` from `gittensor.constants` and uses it for the `/user` request. Three other GitHub HTTP calls in the same file (`get_merge_base_sha`, `get_pull_request_file_changes`, `check_github_issue_closed`) still passed the literal `15`. Switch them to the constant so a future timeout tweak doesn't need to be applied in four places.
Contributor
Author
8 tasks
Collaborator
|
Closing — please consolidate into #917. |
8 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`gittensor/utils/github_api_tools.py` already imports `GITHUB_HTTP_TIMEOUT_SECONDS` from `gittensor.constants` and uses it for the `/user` request (line 242). Three other GitHub HTTP calls in the same file (`get_merge_base_sha`, `get_pull_request_file_changes`, `check_github_issue_closed`) still passed the literal `15`. Switch them to the constant so a future timeout tweak doesn't need to be applied in four places.
Same shape as the merged #455 (use shared constant). 3-line diff, no behaviour change, no new imports.