refactor: remove unused U32_MAX constant - #953
Closed
ebios-star wants to merge 1 commit into
Closed
Conversation
U32_MAX is defined in neurons/base/utils/weight_utils.py but has zero references across gittensor/, neurons/, and tests/. The sibling U16_MAX is actively used by convert_weights_and_uids_for_emit and process_weights_for_netuid. Verified via 'grep -rn U32_MAX' and 'grep -rn 4294967295' — both return only the definition line.
Contributor
Author
|
@anderdc whenever you have a moment, this is a one-line removal of an unused constant. Happy to revise if you'd prefer a different scope. Thanks! |
8 tasks
Collaborator
|
Closing — please consolidate into #917. |
8 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
U32_MAX = 4294967295is defined at the top of neurons/base/utils/weight_utils.py but has zero references anywhere in the codebase. The siblingU16_MAXconstant is actively used byconvert_weights_and_uids_for_emitandprocess_weights_for_netuid.Verified via:
grep -rn U32_MAX— only the definition line.grep -rn 4294967295— only the definition line.Net: -1 line.
Type of Change
Testing
pytest tests/— all 726 tests pass.Checklist