fix(cli): route warnings, errors, logs to stderr - #957
Merged
Conversation
seroperson
force-pushed
the
jq-parse
branch
2 times, most recently
from
May 5, 2026 23:05
b2af9ea to
a61b697
Compare
anderdc
approved these changes
May 8, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #956
Summary
This PR standardizes the output logic: stdout only for valuable data, stderr for logs/warnings/errors etc. Currently existing inconsistency breaks piping flows, like
gitt issues list --json | jq, as stdout may be polluted with info which isn't relates to the calculated result.It's a very common pattern of working with stdout/stderr (see https://clig.dev):
And used in a wide amount of existing tools (
curl,gh,kubectletc).Before
gitt issues list --json | jqfails because of polluted stdoutAfter
gitt issues list --json | jqsucceeds because stdout contains only JSON output, the rest is in stderrTest Plan
I can figure something out if necessary, but I'm really unsure whether it should be tested. Tell me if I need to cover this somehow.