fix: increase closingIssuesReferences limit to 100 and warn on truncation - #971
Closed
597226617 wants to merge 1 commit into
Closed
fix: increase closingIssuesReferences limit to 100 and warn on truncation#971597226617 wants to merge 1 commit into
597226617 wants to merge 1 commit into
Conversation
…tion
_PR_TIMELINE_QUERY requested closingIssuesReferences(first: 20).
A PR closing more than 20 issues had its 21st+ references silently
truncated, causing solver_lookup_failed for the affected miner.
Increased the limit to first: 100 (GitHub per-field maximum) and
added pageInfo { hasNextPage } with a bt.logging.warning when
truncation still occurs, so operators can correlate missed solver
attribution with the warning.
Fixes entrius#934
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_PR_TIMELINE_QUERYrequestedclosingIssuesReferences(first: 20). A PR closing more than 20 issues had its 21st+ references silently truncated, causingsolver_lookup_failedfor the affected miner.Fix
first: 20tofirst: 100(GitHub per-field maximum)pageInfo { hasNextPage }with abt.logging.warningwhen truncation still occurs, so operators can correlate missed solver attribution with the warningFixes #934