fix: recycle treasury emission share when treasury is disabled or unregistered - #975
Closed
aliangm wants to merge 3 commits into
Closed
fix: recycle treasury emission share when treasury is disabled or unregistered#975aliangm wants to merge 3 commits into
aliangm wants to merge 3 commits into
Conversation
…egistered When ISSUES_TREASURY_UID is set to RECYCLE_UID (disabled) or the treasury neuron is not registered on the metagraph, the 15% share was silently dropped. Now it falls through to the recycle pool, matching the behavior of pools 1 and 2 so total emissions sum to 100%.
Collaborator
|
These paths don't fire in production — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Summary
ISSUES_TREASURY_UIDis set toRECYCLE_UID(treasury disabled per constants.py:215) or the treasury neuron is not registered on the metagraph, the 15% treasury share was silently dropped instead of being recycled.recycle_extrawhen empty; pool 3 (treasury) now does the same so total emissions consistently sum to 100%.ISSUES_TREASURY_UID > 0guard with the more directISSUES_TREASURY_UID != RECYCLE_UIDto match the intent stated in the constants comment.Test plan
ISSUES_TREASURY_UID = RECYCLE_UID: recycle UID receives 25% + 15% = 40% (plus any unclaimed OSS/issue-discovery share).Fixes #974