fix(cli): surface skipped validators in miner post/check error path - #990
Merged
anderdc merged 2 commits intoMay 9, 2026
Merged
Conversation
When --min-stake / --min-vtrust eliminate every high-vtrust candidate, _require_validator_axons discarded the `excluded` payload that the success path already exposes and emitted only the generic "No reachable validator axons found on the network." message. Operators hitting this case are exactly the ones who need the diagnostic. Branch on whether `excluded` is non-empty: TTY renders the existing Skipped Validators table before the error, JSON includes the `skipped` array on the error envelope, and the error message names the active thresholds. The original generic message is preserved when the metagraph carries no candidates at all (n=0 or every UID below min_vtrust). entrius#906 introduced the filtering knobs and `excluded` list and wired them into the success path; the error path was missed in the same change.
statxc
force-pushed
the
fix/validator-axons-error-shows-excluded
branch
from
May 5, 2026 02:54
68ca5bf to
1dff66a
Compare
anderdc
approved these changes
May 9, 2026
Contributor
Author
|
Thanks @anderdc |
alpurkan17
pushed a commit
to alpurkan17/gittensor
that referenced
this pull request
May 10, 2026
…ntrius#990) Co-authored-by: Ander <61125407+anderdc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
--min-stake/--min-vtrustexclude every high-vtrust validator, bothgitt miner postandgitt miner checkprinted only the genericNo reachable validator axons found on the network.and discarded theexcludedlist that the success path already exposes.The fix branches on whether
excludedis non-empty and surfaces the same payload — TTY renders the existingSkipped Validatorstable, JSON includesskippedon the error envelope.The original generic message is preserved when the metagraph carries no candidates at all (n=0 or every UID below
min_vtrust).Problem
gittensor/cli/miner_commands/helpers.py:138(pre-fix) called_error('No reachable validator axons found on the network.', json_mode)and exited, regardless of why every candidate dropped out.--min-stake/--min-vtrustand theexcludedlist, wired it into the success path, but the error path was missed.Out of scope
_error()signature changes to accept extra fields — tangential, would touch unrelated callers.Validation
uv run ruff check— cleanuv run ruff format --check— cleanuv run pyright— 0 errorsuv run python -m pytest— 745 passed (+4 new regression tests)Closes #989