Feat: fix the integration test (#854)

* Feat: fix the integration test * modified test and added webhook support * updated description
env0 · May 21, 2024 · 061c442 · 061c442
1 parent 4c5ff4b
commit 061c442
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/client/notification.go b/client/notification.go
@@ -3,9 +3,10 @@ package client
 type NotificationType string
 
 const (
-	NotificationTypeSlack NotificationType = "Slack"
-	NotificationTypeTeams NotificationType = "Teams"
-	NotificationTypeEmail NotificationType = "Email"
+	NotificationTypeSlack   NotificationType = "Slack"
+	NotificationTypeTeams   NotificationType = "Teams"
+	NotificationTypeEmail   NotificationType = "Email"
+	NotificationTypeWebhook NotificationType = "Webhook"
 )
 
 type Notification struct {

diff --git a/env0/resource_notification.go b/env0/resource_notification.go
@@ -30,11 +30,11 @@ func resourceNotification() *schema.Resource {
 			},
 			"type": {
 				Type:        schema.TypeString,
-				Description: "'Slack', 'Teams' or 'Email'",
+				Description: "'Slack', 'Teams', 'Email' or 'Webhook'",
 				Required:    true,
 				ValidateDiagFunc: func(i interface{}, path cty.Path) diag.Diagnostics {
 					notificationType := client.NotificationType(i.(string))
-					if notificationType != client.NotificationTypeSlack && notificationType != client.NotificationTypeTeams && notificationType != client.NotificationTypeEmail {
+					if notificationType != client.NotificationTypeSlack && notificationType != client.NotificationTypeTeams && notificationType != client.NotificationTypeEmail && notificationType != client.NotificationTypeWebhook {
 						return diag.Errorf("Invalid notification type")
 					}
 					return nil

diff --git a/env0/resource_notification_test.go b/env0/resource_notification_test.go
@@ -43,7 +43,7 @@ func TestUnitNotificationResource(t *testing.T) {
 
 	updatedNotification := client.Notification{
 		Id:             notification.Id,
-		Type:           client.NotificationTypeTeams,
+		Type:           client.NotificationTypeWebhook,
 		Name:           "name0-updated",
 		Value:          "https://some.updated.url.1.com",
 		OrganizationId: notification.OrganizationId,

diff --git a/tests/integration/025_notifications/main.tf b/tests/integration/025_notifications/main.tf
@@ -12,7 +12,7 @@ locals {
 
 resource "env0_notification" "test_notification_1" {
   name           = "${local.notification_name_prefix}-1-${random_string.random.result}"
-  type           = "Slack"
+  type           = "Webhook"
   value          = "https://someurl1.com"
   webhook_secret = "my_little_secret"
 }