Skip to content

Commit

Permalink
Fix: project's parent_project_id does not work (#620)
Browse files Browse the repository at this point in the history
* Fix: project's parent_project_id does not work

* modified var name
  • Loading branch information
TomerHeber committed Mar 6, 2023
1 parent 972c508 commit 0f15679
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 10 deletions.
11 changes: 9 additions & 2 deletions client/project.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,15 @@ func (client *ApiClient) ProjectCreate(payload ProjectCreatePayload) (Project, e
return Project{}, err
}

request := map[string]interface{}{"name": payload.Name, "organizationId": organizationId, "description": payload.Description}
err = client.http.Post("/projects", request, &result)
payloadWithOrganizationId := struct {
ProjectCreatePayload
OrganizationId string `json:"organizationId"`
}{
payload,
organizationId,
}

err = client.http.Post("/projects", payloadWithOrganizationId, &result)
if err != nil {
return Project{}, err
}
Expand Down
25 changes: 17 additions & 8 deletions client/project_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (

const projectName = "project_test"
const projectDescription = "project description"
const parentProjectId = "parent_project_id"

var _ = Describe("Project", func() {
var project Project
Expand All @@ -23,20 +24,28 @@ var _ = Describe("Project", func() {
BeforeEach(func() {
mockOrganizationIdCall(organizationId)

httpCall = mockHttpClient.EXPECT().
Post("/projects", map[string]interface{}{
"name": projectName,
"organizationId": organizationId,
"description": projectDescription,
payload := struct {
ProjectCreatePayload
OrganizationId string `json:"organizationId"`
}{
ProjectCreatePayload{
Name: projectName,
Description: projectDescription,
ParentProjectId: parentProjectId,
},
gomock.Any()).
organizationId,
}

httpCall = mockHttpClient.EXPECT().
Post("/projects", payload, gomock.Any()).
Do(func(path string, request interface{}, response *Project) {
*response = mockProject
})

project, _ = apiClient.ProjectCreate(ProjectCreatePayload{
Name: projectName,
Description: projectDescription,
Name: projectName,
Description: projectDescription,
ParentProjectId: parentProjectId,
})
})

Expand Down

0 comments on commit 0f15679

Please sign in to comment.