Fix - fix support in any cnange deploy (#191)

* Fix - fix support in any cnange deploy

env0/resource_environment.go

@@ -77,7 +77,7 @@ func resourceEnvironment() *schema.Resource {
 				Type:        schema.TypeBool,
 				Description: "redeploy only on path changes only",
 				Optional:    true,
-				Default:     false,
+				Default:     true,
 			},
 			"auto_deploy_by_custom_glob": {
 				Type:         schema.TypeString,
@@ -400,13 +400,9 @@ func getUpdatePayload(d *schema.ResourceData) client.EnvironmentUpdate {
 		pullRequestPlanDeployments := d.Get("run_plan_on_pull_requests").(bool)
 		payload.PullRequestPlanDeployments = &pullRequestPlanDeployments
 	}
-	if d.HasChange("auto_deploy_on_path_changes_only") {
-		autoDeployOnPathChangesOnly := d.Get("auto_deploy_on_path_changes_only").(bool)
-		payload.AutoDeployOnPathChangesOnly = &autoDeployOnPathChangesOnly
-	}
-	if d.HasChange("auto_deploy_by_custom_glob") {
-		payload.AutoDeployByCustomGlob = d.Get("auto_deploy_by_custom_glob").(string)
-	}
+	autoDeployOnPathChangesOnly := d.Get("auto_deploy_on_path_changes_only").(bool)
+	payload.AutoDeployOnPathChangesOnly = &autoDeployOnPathChangesOnly
+	payload.AutoDeployByCustomGlob = d.Get("auto_deploy_by_custom_glob").(string)
 
 	return payload
 }

env0/resource_environment_test.go

@@ -43,7 +43,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
 			"force_destroy": true,
 		})
 	}
-	autoDeployOnPathChangesOnlyDefault := false
+	autoDeployOnPathChangesOnlyDefault := true
 	autoDeployByCustomGlobDefault := ""
 	t.Run("Success in create", func(t *testing.T) {
 		testCase := resource.TestCase{
@@ -80,7 +80,9 @@ func TestUnitEnvironmentResource(t *testing.T) {
 				},
 			}).Times(1).Return(environment, nil)
 			mock.EXPECT().EnvironmentUpdate(updatedEnvironment.Id, client.EnvironmentUpdate{
-				Name: updatedEnvironment.Name,
+				Name:                        updatedEnvironment.Name,
+				AutoDeployOnPathChangesOnly: &autoDeployOnPathChangesOnlyDefault,
+				AutoDeployByCustomGlob:      autoDeployByCustomGlobDefault,
 			}).Times(1).Return(updatedEnvironment, nil)
 			mock.EXPECT().ConfigurationVariables(client.ScopeEnvironment, updatedEnvironment.Id).Times(3).Return(client.ConfigurationChanges{}, nil)
 			gomock.InOrder(
@@ -537,10 +539,10 @@ func TestUnitEnvironmentResource(t *testing.T) {
 			},
 
 			ContinuousDeployment:        &falsey,
-			AutoDeployOnPathChangesOnly: &falsey,
+			AutoDeployOnPathChangesOnly: &autoDeployOnPathChangesOnlyDefault,
 			RequiresApproval:            &truthyFruity,
 			PullRequestPlanDeployments:  &falsey,
-			AutoDeployByCustomGlob:      "",
+			AutoDeployByCustomGlob:      autoDeployByCustomGlobDefault,
 		}
 
 		testCase := resource.TestCase{
@@ -581,7 +583,7 @@ func TestUnitEnvironmentResource(t *testing.T) {
 						resource.TestCheckResourceAttr(accessor, "template_id", environment.LatestDeploymentLog.BlueprintId),
 						resource.TestCheckResourceAttr(accessor, "approve_plan_automatically", "false"),
 						resource.TestCheckResourceAttr(accessor, "run_plan_on_pull_requests", "false"),
-						resource.TestCheckResourceAttr(accessor, "auto_deploy_on_path_changes_only", "false"),
+						resource.TestCheckResourceAttr(accessor, "auto_deploy_on_path_changes_only", "true"),
 						resource.TestCheckResourceAttr(accessor, "auto_deploy_by_custom_glob", ""),
 					),
 				},
@@ -594,10 +596,10 @@ func TestUnitEnvironmentResource(t *testing.T) {
 				Name: environment.Name,
 
 				ContinuousDeployment:        &falsey,
-				AutoDeployOnPathChangesOnly: &falsey,
+				AutoDeployOnPathChangesOnly: &autoDeployOnPathChangesOnlyDefault,
 				RequiresApproval:            &truthyFruity,
 				PullRequestPlanDeployments:  &falsey,
-				AutoDeployByCustomGlob:      "",
+				AutoDeployByCustomGlob:      autoDeployByCustomGlobDefault,
 			}).Times(1).Return(environmentAfterUpdate, nil)
 
 			gomock.InOrder(
@@ -713,7 +715,9 @@ func TestUnitEnvironmentResource(t *testing.T) {
 			}).Times(1).Return(environment, nil)
 			mock.EXPECT().ConfigurationVariables(client.ScopeEnvironment, environment.Id).Times(2).Return(client.ConfigurationChanges{}, nil)
 			mock.EXPECT().EnvironmentUpdate(updatedEnvironment.Id, client.EnvironmentUpdate{
-				Name: updatedEnvironment.Name,
+				Name:                        updatedEnvironment.Name,
+				AutoDeployOnPathChangesOnly: &autoDeployOnPathChangesOnlyDefault,
+				AutoDeployByCustomGlob:      autoDeployByCustomGlobDefault,
 			}).Times(1).Return(client.Environment{}, errors.New("error"))
 			mock.EXPECT().Environment(gomock.Any()).Times(2).Return(environment, nil) // 1 after create, 1 before update
 			mock.EXPECT().EnvironmentDestroy(environment.Id).Times(1)