Add ShellCheck Action

[jwendell]

No description provided.

[phlax]

i think this should be exec

[jwendell]

Right, that was my only question on this change. I'm worried the thing after exec does not get executed. ShellCheck warns about it.

We'd need either remove the cleanup section, or suppress the warning, but I think the warning is legit.

[phlax]

fair point - probs best to move it to something like

cleanup() {
    if [[ -f /cleanup.sh ]]; then
        . /cleanup.sh
    fi
}
trap cleanup EXIT

[jwendell]

It doesn't work. exec replaces the current process entirely, including any cleanup trap.

#!/bin/bash

set -eo pipefail

cleanup() {
  echo "b.sh has returned. Exiting a.sh."
}
trap cleanup EXIT

echo "This is a.sh. Invoking b.sh next..."
exec ./b.sh

^^ cleanup() is never called.

[phlax]

argh - thats annoying - something like this could probably work

gosu envoybuild "$@" &
pid=$!

wait $pid
status=$?

if [ -f /cleanup.sh ]; then
    . /cleanup.sh
fi

exit $status

but tbh - im happy if we just remove the cleanup for now - i dont think i was using it anywhere given it wasnt working

[jwendell]

What's your intention with exec? AFAICT gosu already performs an exec:

Once the user/group is processed, we switch to that user, then we exec the specified process and gosu itself is no longer resident or involved in the process lifecycle at all.

Taken from its README.

[phlax]

keeping the proc as pid 1

[phlax]

and ensuring the signals are properly handled - pretty sure you should exec gosu in an entrypoint

[jwendell]

Right. I'll remove the cleanup for now.

[phlax]

can we do least indent for arrays in yaml files please

sort of related .. we have envoy.code.check - which can run is python and can run in ci etc - it has both yamllint and shellcheck

i reckon lets land this (with cleaned up yaml) and i can switch to the envoy one after